chore(MBA-1550): Upgrade Java from 17 to 21#172
Open
devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
Open
chore(MBA-1550): Upgrade Java from 17 to 21#172devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
Conversation
- Update java.version property from 17 to 21 in pom.xml - Update maven-compiler-plugin source/target from 1.8 to 21 - Update Dockerfile build stage from maven:3.8.3-openjdk-17 to maven:3.9-eclipse-temurin-21 - Update Dockerfile runtime stage from openjdk:17-alpine to eclipse-temurin:21-jre-alpine
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Devin Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the application's Java version from 17 to 21 as specified in MBA-1550. All compilation targets and Docker base images are updated accordingly.
Changes:
pom.xml: Updatedjava.versionproperty from17to21pom.xml: Updatedmaven-compiler-pluginsource/target from1.8to21(was incorrectly set to Java 8)Dockerfile: Updated build stage frommaven:3.8.3-openjdk-17tomaven:3.9-eclipse-temurin-21Dockerfile: Updated runtime stage fromopenjdk:17-alpinetoeclipse-temurin:21-jre-alpine(uses Eclipse Temurin, the modern successor to deprecated OpenJDK Docker images)Build validated locally:
mvn clean compileandmvn packageboth succeed with JDK 21.Review & Testing Checklist for Human
java -jar target/bankapp-0.0.1-SNAPSHOT.jar)docker build -t bankapp .Notes
maven-compiler-pluginsource/target was previously set to1.8(Java 8), which was inconsistent with thejava.versionproperty of17. This has been corrected to21to match the new Java version.openjdkimages toeclipse-temurin, which is the recommended replacement.openjdk-17-jreare for Jenkins installation and are out of scope for this change.Link to Devin session: https://app.devin.ai/sessions/51d3c1ca0b2d4dcda99fcfeee54209c9